Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h

Issue 2650563002: Pass WebState to NativeAppNavigationController (Closed)
Patch Set: Add chrome_web_test support Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h
diff --git a/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h b/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h
index 0fc92b4a16765ac05761c81d1d80a3f8fdd3a665..2554214703d6dcc502492e0c37a9d8bdf09967b6 100644
--- a/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h
+++ b/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h
@@ -16,15 +16,24 @@ namespace net {
class URLRequestContextGetter;
} // namespace net
+namespace web {
+class WebState;
+} // namespace web
+
// NativeAppNavigationController brings up a GAL Infobar if the webpage directs
// it to do so and there are no other circumstances that would suppress its
// display.
@interface NativeAppNavigationController
: NSObject<CRWWebControllerObserver, NativeAppNavigationControllerProtocol>
-// Designated initializer.
-- (id)initWithRequestContextGetter:(net::URLRequestContextGetter*)context
- tab:(Tab*)tab;
+// Use -initWithWebState:requestContextGetter:tab: instead.
+- (instancetype)init NS_UNAVAILABLE;
rohitrao (ping after 24h) 2017/01/24 14:24:56 We generally put the unavailable initializers afte
pkl (ping after 24h if needed) 2017/01/26 00:30:17 Done.
+
+// Designated initializer. The use of |tab| will be phased out in the future
+// when all the information needed can be fulfilled by |webState|.
+- (instancetype)initWithWebState:(web::WebState*)webState
+ requestContextGetter:(net::URLRequestContextGetter*)context
+ tab:(Tab*)tab NS_DESIGNATED_INITIALIZER;
// Copies the list of applications possibly being installed and register to be
// notified of their installation.

Powered by Google App Engine
This is Rietveld 408576698