Pass WebState to NativeAppNavigationController

ios/chrome/browser/native_app_launcher/native_app_navigation_utils.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/native_app_launcher/native_app_navigation_utils.h"
+
+#include "base/logging.h"
+#import "ios/web/navigation/navigation_manager_impl.h"

[Eugene But (OOO till 7-30), 2017/01/26 01:04:38]

do we need this include?

[pkl (ping after 24h if needed), 2017/01/26 02:26:28]

Not this one, but we do need ios/web/public/navigation_manager.h. Thanks for
catching this.

+#include "ios/web/public/navigation_item.h"
+#include "ios/web/public/web_state/web_state.h"

[Eugene But (OOO till 7-30), 2017/01/26 01:04:38]

s/include/import

[pkl (ping after 24h if needed), 2017/01/26 02:26:28]

web_state.h is all C++ code, so should be #include (not #import).

[Eugene But (OOO till 7-30), 2017/01/26 03:10:02]

Line 26 is Objective-C code.

[pkl (ping after 24h if needed), 2017/01/26 19:44:24]

Done.

+
+namespace native_app_launcher {
+
+bool IsLinkNavigation(web::WebState* webState) {

[Eugene But (OOO till 7-30), 2017/01/26 01:04:39]

Please use C++ Style for variables

[pkl (ping after 24h if needed), 2017/01/26 02:26:28]

Done.

+  web::NavigationManager* navigationManager = webState->GetNavigationManager();
+  if (!navigationManager)
+    return false;

[Eugene But (OOO till 7-30), 2017/01/26 01:04:38]

Can this ever happen? I think NavigationManager lifetime is the same as WebState
lifetime.

[pkl (ping after 24h if needed), 2017/01/26 02:26:28]

web_state.h says "Can never return null". Cool! Turning this into a DCHECK.

+  int index = navigationManager->GetCurrentItemIndex();
+  // Walks backward on the navigation items for the first item that is not a

[Eugene But (OOO till 7-30), 2017/01/26 01:04:38]

nit: s/Walks/Walk

[pkl (ping after 24h if needed), 2017/01/26 02:26:28]

I recall that comments should be third-person singular, e.g. "Returns foo" and
not "Return foo". In this case, "Walks".

[Eugene But (OOO till 7-30), 2017/01/26 03:10:02]

I guess you referring to Style Guide: "Use descriptive form ("Opens the file")
rather than imperative form ("Open the file") for method and function
comments.". So we normally use descriptive for functions and method, but it's
not an issue.

[pkl (ping after 24h if needed), 2017/01/26 19:44:24]

Acknowledged.

+  // redirect.
+  while (index >= 0) {
+    web::NavigationItem* item = navigationManager->GetItemAtIndex(index);
+    DCHECK(item);
+    ui::PageTransition currentTransition = item->GetTransitionType();
+    // Checks non-redirect entries for transitions that are either links or
+    // bookmarks.
+    if ((currentTransition & ui::PAGE_TRANSITION_IS_REDIRECT_MASK) == 0) {
+      return PageTransitionCoreTypeIs(currentTransition,
+                                      ui::PAGE_TRANSITION_LINK) ||
+             PageTransitionCoreTypeIs(currentTransition,
+                                      ui::PAGE_TRANSITION_AUTO_BOOKMARK);
+    }
+    --index;
+  }
+  return false;
+}
+
+}  // namespace native_app_launcher