ios/chrome/browser/native_app_launcher/DEPS - Issue 2650563002: Pass WebState to NativeAppNavigationController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/native_app_launcher/DEPS

Issue 2650563002: Pass WebState to NativeAppNavigationController (Closed)

Patch Set: IsLinkNavigation() is now a util function w/ unit tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/native_app_launcher/BUILD.gn ('K') | « ios/chrome/browser/native_app_launcher/BUILD.gn ('k') | ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h » ('j') | ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 specific_include_rules = {	1 specific_include_rules = {

2 # TODO(crbug.com/619984): Remove this exception.	2 # TODO(crbug.com/619984): Remove this exception.
	Eugene But (OOO till 7-30) 2017/01/26 01:04:38 crbug.com/619984 is about using GetLastUserItem, w crbug.com/619984 is about using GetLastUserItem, which you just removed. Can we remove native_app_navigation_controller\.mm$ exception now? pkl (ping after 24h if needed) 2017/01/26 02:26:28 Done. Show quoted text On 2017/01/26 01:04:38, Eugene But wrote: > crbug.com/619984 is about using GetLastUserItem, which you just removed. Can we > remove native_app_navigation_controller\.mm$ exception now? Done.
3 "^native_app_navigation_controller\.mm$": [	3 "^native_app_navigation_controller\.mm$": [

4 "+ios/web/navigation/navigation_manager_impl.h",	4 "+ios/web/navigation/navigation_manager_impl.h",

5 ],	5 ],

	6 "^native_app_navigation_utils\.mm$": [

	7 "+ios/web/navigation/navigation_manager_impl.h",
	Eugene But (OOO till 7-30) 2017/01/26 01:04:38 Do we need this exception? Do we need this exception? pkl (ping after 24h if needed) 2017/01/26 02:26:28 Yes, it is needed. Show quoted text On 2017/01/26 01:04:38, Eugene But wrote: > Do we need this exception? Yes, it is needed.
	8 ],

	9 "^native_app_navigation_utils_unittest\.mm$": [
	Eugene But (OOO till 7-30) 2017/01/26 01:04:38 Could you please file a bug to remove private API Could you please file a bug to remove private API usage from unittest. pkl (ping after 24h if needed) 2017/01/26 02:26:28 I recycled the crbug quoted above because it is re Show quoted text On 2017/01/26 01:04:38, Eugene But wrote: > Could you please file a bug to remove private API usage from unittest. I recycled the crbug quoted above because it is really the same violation but moved to a different file.
	10 "+ios/web/navigation/crw_session_controller.h",

	11 "+ios/web/navigation/navigation_manager_impl.h",

	12 "+ios/web/web_state/web_state_impl.h",

	13 ],

6 }	14 }

OLD	NEW