Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2650543002: DevTools: render console level filter as drop box. (Closed)
Patch Set: Introduce progress monitor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index 1d5ba2b85a5636d3520aa8ad5d30769c7c20ef34..2af56fe449bde8209224b772da38bfe6aaaa3b5f 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -687,13 +687,13 @@ Timeline.TimelinePanel = class extends UI.Panel {
p = centered.createChild('p');
p.appendChild(UI.formatLocalized(
'To capture a new recording, click the record toolbar button or hit %s. ' +
- 'To evaluate page load performance, hit %s to record the reload.',
+ 'To evaluate page load performance, hit %s to record the reload.',
[recordNode, reloadNode]));
p = centered.createChild('p');
p.appendChild(UI.formatLocalized(
'After recording, select an area of interest in the overview by dragging. ' +
- 'Then, zoom and pan the timeline with the mousewheel or %s keys.',
+ 'Then, zoom and pan the timeline with the mousewheel or %s keys.',
[navigateNode]));
p = centered.createChild('p');
@@ -705,7 +705,7 @@ Timeline.TimelinePanel = class extends UI.Panel {
p = centered.createChild('p', 'timeline-landing-warning');
p.appendChild(UI.formatLocalized(
'The %s panel has been enriched with the JavaScript profiler capabilities and is now called %s.%s' +
- 'You can find the legacy JavaScript CPU profiler under %s%s \u2192 More Tools \u2192 JavaScript Profiler.',
+ 'You can find the legacy JavaScript CPU profiler under %s%s \u2192 More Tools \u2192 JavaScript Profiler.',
[timelineSpan, performanceSpan, createElement('p'), createElement('br'), UI.Icon.create('largeicon-menu')]));
this._landingPage.show(this._statusPaneContainer);
@@ -1634,11 +1634,12 @@ Timeline.TimelineFilters = class extends Common.Object {
if (!durationMs) {
durationOption.label = Common.UIString('All');
durationOption.title = Common.UIString('Show all records');
+ durationOption.default = true;
} else {
durationOption.label = Common.UIString('\u2265 %dms', durationMs);
durationOption.title = Common.UIString('Hide records shorter than %dms', durationMs);
}
- durationOption.value = durationMs;
+ durationOption.value = String(durationMs);
durationOptions.push(durationOption);
}
var durationFilterUI = new UI.ComboBoxFilterUI(durationOptions);

Powered by Google App Engine
This is Rietveld 408576698