Issue 265054: Sync: Convert AddressWatchThread from pthreads to chrome threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265054: Sync: Convert AddressWatchThread from pthreads to chrome threads. (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sync: Remove pthreads from syncapi. Convert AddressWatchThread from pthreads to chrome threads. BUG=19895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28514

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -50 lines)			Patch
	M	chrome/browser/sync/engine/syncapi.cc	View	1 2	10 chunks	+57 lines, -50 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

11 years, 2 months ago (2009-10-09 00:39:06 UTC) #2

LGTM

http://codereview.chromium.org/265054/diff/3001/4001
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/265054/diff/3001/4001#newcode88
Line 88: AddressWatchTask(AddressWatchTaskParams* params) : params_(params){}
explicit (gotcha!)  Also, double-check your whitespace decisions.

Expand Messages | Collapse Messages