Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 265054: Sync: Convert AddressWatchThread from pthreads to chrome threads. (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana
Visibility:
Public.

Description

Sync: Remove pthreads from syncapi. Convert AddressWatchThread from pthreads to chrome threads. BUG=19895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28514

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -50 lines) Patch
M chrome/browser/sync/engine/syncapi.cc View 1 2 10 chunks +57 lines, -50 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tim (not reviewing)
11 years, 2 months ago (2009-10-09 00:25:03 UTC) #1
ncarter (slow)
11 years, 2 months ago (2009-10-09 00:39:06 UTC) #2
LGTM

http://codereview.chromium.org/265054/diff/3001/4001
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/265054/diff/3001/4001#newcode88
Line 88: AddressWatchTask(AddressWatchTaskParams* params) : params_(params){}
explicit (gotcha!)  Also, double-check your whitespace decisions.

Powered by Google App Engine
This is Rietveld 408576698