This gets mojo_launcher.so a little further along toward running.

This gets mojo_launcher.so a little further along toward running.

It still doesn't run though.

R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268261

[Ben Goodger (Google), 2014-05-02 22:58:01]

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/native_viewport_x11.cc (right):

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/native_viewport_x11.cc:57: if
(!event_source_.get()) {
nit: no braces

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/native_viewport_x11.cc:58:
ui::PlatformEventSource::CreateDefault();
don't you need to assign to event_source_ here?

[Aaron Boodman, 2014-05-05 18:18:31]

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/native_viewport_x11.cc (right):

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/native_viewport_x11.cc:57: if
(!event_source_.get()) {
On 2014/05/02 22:58:02, Ben Goodger (Google) wrote:
> nit: no braces

Done.

https://codereview.chromium.org/265053005/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/native_viewport_x11.cc:58:
ui::PlatformEventSource::CreateDefault();
On 2014/05/02 22:58:02, Ben Goodger (Google) wrote:
> don't you need to assign to event_source_ here?

whoopsie.

[Ben Goodger (Google), 2014-05-05 18:24:30]

lgtm

[Aaron Boodman, 2014-05-05 18:25:45]

The CQ bit was checked by aa@chromium.org

[commit-bot: I haz the power, 2014-05-05 18:27:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aa@chromium.org/265053005/20001

[Aaron Boodman, 2014-05-05 20:28:40]

Committed patchset #2 manually as r268261 (presubmit successful).