dart2js-kernel: handle [TypeLiteral]s that are function types

pkg/compiler/lib/src/ssa/builder_kernel.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart';
 import '../common.dart';
 import '../common/codegen.dart' show CodegenRegistry, CodegenWorkItem;
 import '../common/names.dart';
@@ skipping 1756 matching lines @@
   }
 
   @override
   void visitTypeLiteral(ir.TypeLiteral typeLiteral) {
     ir.DartType type = typeLiteral.type;
     if (type is ir.InterfaceType || type is ir.DynamicType) {
       ConstantValue constant = astAdapter.getConstantForType(type);
       stack.add(graph.addConstant(constant, closedWorld));
       return;
     }
-    if (type is ir.TypeParameterType) {
-      // TODO(sra): Convert the type logic here to use ir.DartType.
-      ResolutionDartType dartType = astAdapter.getDartType(type);
-      dartType = localsHandler.substInContext(dartType);
-      HInstruction value = typeBuilder.analyzeTypeArgument(
-          dartType, sourceElement,
-          sourceInformation: null);
-      _pushStaticInvocation(astAdapter.runtimeTypeToString,
-          <HInstruction>[value], commonMasks.stringType);
-      _pushStaticInvocation(astAdapter.createRuntimeType, <HInstruction>[pop()],
-          astAdapter.createRuntimeTypeReturnType);
-      return;
-    }
-    // TODO(27394): Function types observed. Where are they from?
-    defaultExpression(typeLiteral);
-    return;
+    // For other types (e.g. TypeParameterType, function types from expanded
+    // typedefs), look-up or construct a reified type representation and convert
+    // to a RuntimeType.
+
+    // TODO(sra): Convert the type logic here to use ir.DartType.
+    ResolutionDartType dartType = astAdapter.getDartType(type);
+    dartType = localsHandler.substInContext(dartType);
+    HInstruction value = typeBuilder.analyzeTypeArgument(
+        dartType, sourceElement,
+        sourceInformation: null);
+    _pushStaticInvocation(astAdapter.runtimeTypeToString,
+                          <HInstruction>[value], commonMasks.stringType);
+    _pushStaticInvocation(astAdapter.createRuntimeType, <HInstruction>[pop()],
+                          astAdapter.createRuntimeTypeReturnType);
   }
 
   @override
   void visitStaticGet(ir.StaticGet staticGet) {
     ir.Member staticTarget = staticGet.target;
     if (staticTarget is ir.Procedure &&
         staticTarget.kind == ir.ProcedureKind.Getter) {
       // Invoke the getter
       _pushStaticInvocation(staticTarget, const <HInstruction>[],
           astAdapter.returnTypeOf(staticTarget));
@@ skipping 1264 matching lines @@
     enterBlock.setBlockFlow(
         new HTryBlockInformation(
             kernelBuilder.wrapStatementGraph(bodyGraph),
             exception,
             kernelBuilder.wrapStatementGraph(catchGraph),
             kernelBuilder.wrapStatementGraph(finallyGraph)),
         exitBlock);
     kernelBuilder.inTryStatement = previouslyInTryStatement;
   }
 }