Webapp share dialog is not closed when client end of the connection is closed

remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc

Index: remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
diff --git a/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc b/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
index 9e4ef749b1572c93be9ffada45490fc0efe478a7..85b5ab2cb30f65c769a50f039f60557d32940ae7 100644
--- a/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
+++ b/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
@@ -114,9 +114,8 @@ class It2MeConfirmationDialogProxyTest : public testing::Test {
   base::RunLoop run_loop_;
   base::Thread dialog_thread_;
 
-  // |dialog_| is owned by |dialog_proxy_| but we keep an alias for test
-  // purposes.
-  StubIt2MeConfirmationDialog* dialog_;
+  // |dialog_| is owned by |dialog_proxy_| but we keep an alias for testing.
+  StubIt2MeConfirmationDialog* dialog_ = nullptr;
   std::unique_ptr<It2MeConfirmationDialogProxy> dialog_proxy_;
 };
 
@@ -124,9 +123,11 @@ It2MeConfirmationDialogProxyTest::It2MeConfirmationDialogProxyTest()
     : dialog_thread_("test dialog thread") {
   dialog_thread_.Start();
 
-  dialog_ = new StubIt2MeConfirmationDialog(dialog_task_runner());
-  dialog_proxy_.reset(new It2MeConfirmationDialogProxy(
-      dialog_task_runner(), std::unique_ptr<It2MeConfirmationDialog>(dialog_)));
+  std::unique_ptr<StubIt2MeConfirmationDialog> dialog(

[Sergey Ulanov, 2017/03/14 21:50:35]

auto dialog = base::MakeUnique<StubIt2MeConfirmationDialog>(
    dialog_task_runner());

This is shorter and more readable.

[joedow, 2017/03/16 21:39:10]

Done.

+      new StubIt2MeConfirmationDialog(dialog_task_runner()));
+  dialog_ = dialog.get();
+  dialog_proxy_.reset(new It2MeConfirmationDialogProxy(dialog_task_runner(),
+                                                       std::move(dialog)));
 }
 
 It2MeConfirmationDialogProxyTest::~It2MeConfirmationDialogProxyTest() {}