Webapp share dialog is not closed when client end of the connection is closed

remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc

Index: remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
diff --git a/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc b/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
index 9e4ef749b1572c93be9ffada45490fc0efe478a7..25d72ef6fb2cb8aea5c8f9d20c2f0a6b561505d9 100644
--- a/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
+++ b/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
@@ -116,7 +116,7 @@ class It2MeConfirmationDialogProxyTest : public testing::Test {
 
   // |dialog_| is owned by |dialog_proxy_| but we keep an alias for test
   // purposes.
-  StubIt2MeConfirmationDialog* dialog_;
+  StubIt2MeConfirmationDialog* dialog_ = nullptr;
   std::unique_ptr<It2MeConfirmationDialogProxy> dialog_proxy_;
 };
 
@@ -131,7 +131,25 @@ It2MeConfirmationDialogProxyTest::It2MeConfirmationDialogProxyTest()
 
 It2MeConfirmationDialogProxyTest::~It2MeConfirmationDialogProxyTest() {}
 
-TEST_F(It2MeConfirmationDialogProxyTest, Show) {
+TEST_F(It2MeConfirmationDialogProxyTest, ShowAction_OkButtonClicked) {
+  ResultCallbackTarget callback_target(main_task_runner());
+
+  EXPECT_CALL(*dialog(), OnShow())
+      .WillOnce(InvokeWithoutArgs(CreateFunctor(
+          &StubIt2MeConfirmationDialog::ReportResult,
+          base::Unretained(dialog()), It2MeConfirmationDialog::Result::OK)));
+
+  EXPECT_CALL(callback_target,
+              OnDialogResult(It2MeConfirmationDialog::Result::OK))
+      .WillOnce(
+          InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
+
+  dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
+
+  Run();
+}
+
+TEST_F(It2MeConfirmationDialogProxyTest, ShowAction_CancelButtonClicked) {
   ResultCallbackTarget callback_target(main_task_runner());
 
   EXPECT_CALL(*dialog(), OnShow())
@@ -152,4 +170,24 @@ TEST_F(It2MeConfirmationDialogProxyTest, Show) {
   Run();
 }
 
+TEST_F(It2MeConfirmationDialogProxyTest, ShowActionCancelled_OkButtonClicked) {
+  ResultCallbackTarget callback_target(main_task_runner());
+
+  EXPECT_CALL(*dialog(), OnShow())
+      .WillOnce(InvokeWithoutArgs(CreateFunctor(
+          &StubIt2MeConfirmationDialog::ReportResult,
+          base::Unretained(dialog()), It2MeConfirmationDialog::Result::OK)));
+
+  EXPECT_CALL(callback_target,
+              OnDialogResult(It2MeConfirmationDialog::Result::CANCEL))
+      .WillOnce(
+          InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
+
+  dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
+
+  dialog_proxy()->Cancel();
+
+  Run();
+}
+
 }  // namespace remoting