Webapp share dialog is not closed when client end of the connection is closed

remoting/host/it2me/it2me_confirmation_dialog_proxy.h

Index: remoting/host/it2me/it2me_confirmation_dialog_proxy.h
diff --git a/remoting/host/it2me/it2me_confirmation_dialog_proxy.h b/remoting/host/it2me/it2me_confirmation_dialog_proxy.h
index 42ca368822e9ba91b4aa89b5c0b97ceb46972dc2..445a24afe6f4abb6032eda9ffbe91660e10eea7f 100644
--- a/remoting/host/it2me/it2me_confirmation_dialog_proxy.h
+++ b/remoting/host/it2me/it2me_confirmation_dialog_proxy.h
@@ -19,8 +19,7 @@ namespace remoting {
 class It2MeConfirmationDialogProxy : public It2MeConfirmationDialog {
  public:
   // |ui_task_runner| must be the UI thread. It will be used to call into the
-  // wrapped dialog.
-  // |dialog| is the dialog being wrapped.
+  // wrapped dialog.  |dialog| is the dialog being wrapped.
   It2MeConfirmationDialogProxy(
       scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
       std::unique_ptr<It2MeConfirmationDialog> dialog);
@@ -31,6 +30,11 @@ class It2MeConfirmationDialogProxy : public It2MeConfirmationDialog {
   void Show(const std::string& remote_user_email,
             const It2MeConfirmationDialog::ResultCallback& callback) override;
 
+  // Returns a cancelled result if the dialog is currently open.  Should be used
+  // when the dialog has been invalidated, such as the connection being closed
+  // from the client side.
+  void Cancel();

[Sergey Ulanov, 2017/01/20 20:05:43]

I don't think we really need this method. The caller can just delete the proxy
to hide the dialog. It also knows if the callback has been called. Also calling
callback(CANCEL) doesn't seem like the right thing to do: CANCEL indicates that
the user clicked "Cancel" button, which is not the case here.

[joedow, 2017/03/14 16:46:36]

Done.

+
  private:
   class Core;