Webapp share dialog is not closed when client end of the connection is closed

remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/it2me/it2me_confirmation_dialog_proxy.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
@@ skipping 98 matching lines @@
     return dialog_;
   }
 
  private:
   base::MessageLoop message_loop_;
   base::RunLoop run_loop_;
   base::Thread dialog_thread_;
 
   // |dialog_| is owned by |dialog_proxy_| but we keep an alias for test
   // purposes.
-  StubIt2MeConfirmationDialog* dialog_;
+  StubIt2MeConfirmationDialog* dialog_ = nullptr;
   std::unique_ptr<It2MeConfirmationDialogProxy> dialog_proxy_;
 };
 
 It2MeConfirmationDialogProxyTest::It2MeConfirmationDialogProxyTest()
     : dialog_thread_("test dialog thread") {
   dialog_thread_.Start();
 
   dialog_ = new StubIt2MeConfirmationDialog(dialog_task_runner());
   dialog_proxy_.reset(new It2MeConfirmationDialogProxy(
       dialog_task_runner(), std::unique_ptr<It2MeConfirmationDialog>(dialog_)));
 }
 
 It2MeConfirmationDialogProxyTest::~It2MeConfirmationDialogProxyTest() {}
 
-TEST_F(It2MeConfirmationDialogProxyTest, Show) {
+TEST_F(It2MeConfirmationDialogProxyTest, ShowAction_OkButtonClicked) {
   ResultCallbackTarget callback_target(main_task_runner());
 
   EXPECT_CALL(*dialog(), OnShow())
+      .WillOnce(InvokeWithoutArgs(CreateFunctor(
+          &StubIt2MeConfirmationDialog::ReportResult,
+          base::Unretained(dialog()), It2MeConfirmationDialog::Result::OK)));
+
+  EXPECT_CALL(callback_target,
+              OnDialogResult(It2MeConfirmationDialog::Result::OK))
+      .WillOnce(
+          InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
+
+  dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
+
+  Run();
+}
+
+TEST_F(It2MeConfirmationDialogProxyTest, ShowAction_CancelButtonClicked) {
+  ResultCallbackTarget callback_target(main_task_runner());
+
+  EXPECT_CALL(*dialog(), OnShow())
       .WillOnce(
           InvokeWithoutArgs(
               CreateFunctor(
                   &StubIt2MeConfirmationDialog::ReportResult,
                   base::Unretained(dialog()),
                   It2MeConfirmationDialog::Result::CANCEL)));
 
   EXPECT_CALL(callback_target,
               OnDialogResult(It2MeConfirmationDialog::Result::CANCEL))
       .WillOnce(
           InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
 
   dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
 
   Run();
 }
 
+TEST_F(It2MeConfirmationDialogProxyTest, ShowActionCancelled_OkButtonClicked) {
+  ResultCallbackTarget callback_target(main_task_runner());
+
+  EXPECT_CALL(*dialog(), OnShow())
+      .WillOnce(InvokeWithoutArgs(CreateFunctor(
+          &StubIt2MeConfirmationDialog::ReportResult,
+          base::Unretained(dialog()), It2MeConfirmationDialog::Result::OK)));
+
+  EXPECT_CALL(callback_target,
+              OnDialogResult(It2MeConfirmationDialog::Result::CANCEL))
+      .WillOnce(
+          InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
+
+  dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
+
+  dialog_proxy()->Cancel();
+
+  Run();
+}
+
 }  // namespace remoting