Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7746)

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 265044: Eliminate WebView::GetDelegate and replace RenderViewSet with a linked list o... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/event_bindings.cc
===================================================================
--- chrome/renderer/extensions/event_bindings.cc (revision 28382)
+++ chrome/renderer/extensions/event_bindings.cc (working copy)
@@ -253,8 +253,8 @@
}
RenderView* render_view = NULL;
- if (frame->view() && frame->view()->GetDelegate())
- render_view = static_cast<RenderView*>(frame->view()->GetDelegate());
+ if (frame->view())
+ render_view = RenderView::FromWebView(frame->view());
contexts.push_back(linked_ptr<ContextInfo>(
new ContextInfo(persistent_context, extension_id, parent_context,
@@ -298,7 +298,7 @@
continue;
v8::Handle<v8::Value> retval = CallFunctionInContext((*it)->context,
function_name, argc, argv);
- // In debug, the js will validate the event parameters and return a
+ // In debug, the js will validate the event parameters and return a
// string if a validation error has occured.
// TODO(rafaelw): Consider only doing this check if function_name ==
// "Event.dispatchJSON".

Powered by Google App Engine
This is Rietveld 408576698