Issue 265044: Eliminate WebView::GetDelegate and replace RenderViewSet with a linked list o...

Issue 265044: Eliminate WebView::GetDelegate and replace RenderViewSet with a linked list o... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, brettw+cc_chromium.org, darin (slow to review), jam, Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Eliminate WebView::GetDelegate and replace RenderViewSet with a map from WebView to RenderView. R=mpcomplete BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28515

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -85 lines)			Patch
M	chrome/renderer/extensions/bindings_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View		3 chunks	+74 lines, -57 lines	0 comments	Download
M	chrome/renderer/external_extension.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2	6 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	6 chunks	+31 lines, -6 lines	2 comments	Download
A	chrome/renderer/render_view_visitor.h	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_widget.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webview.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/webview_impl.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

Oops, just noticed something. http://codereview.chromium.org/265044/diff/4005/3015 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/265044/diff/4005/3015#newcode273 Line 273: visitor->Visit(it->second); I think you ...

11 years, 2 months ago (2009-10-09 00:25:14 UTC) #3

darin (slow to review)

11 years, 2 months ago (2009-10-09 03:52:30 UTC) #4

http://codereview.chromium.org/265044/diff/4005/3015
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/265044/diff/4005/3015#newcode273
Line 273: visitor->Visit(it->second);
On 2009/10/09 00:25:14, Matt Perry wrote:
> I think you want to break if this returns false?

Yes, thanks for catching that!

Expand Messages | Collapse Messages