Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 265043003: Fix test data copying on iOS (Closed)

Created:
6 years, 7 months ago by stuartmorgan
Modified:
6 years, 7 months ago
Reviewers:
lliabraa, Nico
CC:
chromium-reviews, rohitrao (ping after 24h)
Visibility:
Public.

Description

Fix test data copying on iOS gyp can cache and re-use the output of scripts that have the same invocation, and all the test data copying uses "test/data". This is a relative path, so it's not really the same command, causing flaky compile failures. This works around the bug by artificially introducing variation into the invocation string. NOTRY=true BUG=369533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/copy_test_data_ios.gypi View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
stuartmorgan
6 years, 7 months ago (2014-05-02 19:21:54 UTC) #1
stuartmorgan
Forgot Lane is a committer; re-routing review.
6 years, 7 months ago (2014-05-02 19:29:14 UTC) #2
Nico
lgtm
6 years, 7 months ago (2014-05-02 19:44:27 UTC) #3
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 7 months ago (2014-05-02 19:47:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/265043003/1
6 years, 7 months ago (2014-05-02 19:48:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:01:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:01:58 UTC) #7
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 7 months ago (2014-05-02 20:05:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/265043003/1
6 years, 7 months ago (2014-05-02 20:06:23 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:12:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:12:56 UTC) #11
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 7 months ago (2014-05-02 20:42:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/265043003/1
6 years, 7 months ago (2014-05-02 20:42:40 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 21:16:14 UTC) #14
Message was sent while issue was closed.
Change committed as 267919

Powered by Google App Engine
This is Rietveld 408576698