Don't attempt to recover from missing strings.

Don't attempt to recover from missing strings.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9569b6aebd78643b8e6372551d66d2c7f99752f

[ahe, 2017-01-25 12:38:16]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[ahe, 2017-01-25 12:38:17]

All co19 tests should be parsing now.

https://codereview.chromium.org/2650413002/diff/1/pkg/compiler/lib/src/parser...
File pkg/compiler/lib/src/parser/element_listener.dart (left):

https://codereview.chromium.org/2650413002/diff/1/pkg/compiler/lib/src/parser...
pkg/compiler/lib/src/parser/element_listener.dart:615: errorCode =
MessageKind.STRING_EXPECTED;
Not the correct error code, this is a resolution error which includes an
expected type.

https://codereview.chromium.org/2650413002/diff/1/pkg/compiler/lib/src/parser...
File pkg/compiler/lib/src/parser/element_listener.dart (right):

https://codereview.chromium.org/2650413002/diff/1/pkg/compiler/lib/src/parser...
pkg/compiler/lib/src/parser/element_listener.dart:615: reportFatalError(
This restores the previous behavior in dart2js.

The reason why we can't recover is parseLiteralStringOrRecoverExpression which
doesn't work when diet parsing. This is because we override parseExpression with
skipExpression, so an element is missing from the stack. Also, if you try to
push null, more stuff breaks.

[ahe, 2017-01-25 12:39:27]

On 2017/01/25 12:38:17, ahe wrote:
> All co19 tests should be parsing now.

Also, most of them are *passing*, not all, just restored status quo :-)

[Johnni Winther, 2017-01-25 13:45:41]

lgtm

[ahe, 2017-01-25 13:48:03]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-01-25 13:50:53]

Patchset #2 (id:40001) has been deleted

[ahe, 2017-01-25 13:52:51]

Thank you, Johnni.

Uploaded a new patch set with minor tweaks: prevent this test from being run by
test.dart, and correctly enable batch mode.

[ahe, 2017-01-25 13:53:10]

Description was changed from

==========
Don't attempt to recover from missing strings.
==========

to

==========
Don't attempt to recover from missing strings.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c9569b6aebd78643b8e6372551d66d2c7f99752f
==========

[ahe, 2017-01-25 13:53:11]

Committed patchset #2 (id:60001) manually as
c9569b6aebd78643b8e6372551d66d2c7f99752f (presubmit successful).