third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2650403006: Remove PlatformMouseEvent and use WebMouseEvent instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2650403006: Remove PlatformMouseEvent and use WebMouseEvent instead (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 7b2b88f4b059ea43c4ecfec2b2b5485d281c1ffc..97bf482a6c9ff11ee298c762097a9b012dd0367e 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -446,7 +446,9 @@ void PopupMenuImpl::setValueAndClosePopup(int numValue,

// We dispatch events on the owner element to match the legacy behavior.

// Other browsers dispatch click events before and after showing the popup.

if (m_ownerElement) {

- PlatformMouseEvent event;

+ // TODO(dtapuska): Why is this event positionless?

+ WebMouseEvent event;

+ event.setFrameScale(1);

Element* owner = &ownerElement();

owner->dispatchMouseEvent(event, EventTypeNames::mouseup);

owner->dispatchMouseEvent(event, EventTypeNames::click);