Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2650403006: Remove PlatformMouseEvent and use WebMouseEvent instead (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 0e621fd248e08703c92a64d33dc6b422f32ea9b8..5cf445a1c85168a3c6ab54e9763d8a0a5e30c2f4 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -97,7 +97,6 @@
#include "platform/Cursor.h"
#include "platform/Histogram.h"
#include "platform/KeyboardCodes.h"
-#include "platform/PlatformMouseEvent.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/UserGestureIndicator.h"
#include "platform/animation/CompositorAnimationHost.h"
@@ -556,10 +555,13 @@ void WebViewImpl::mouseContextMenu(const WebMouseEvent& event) {
m_page->contextMenuController().clearContextMenu();
- PlatformMouseEventBuilder pme(mainFrameImpl()->frameView(), event);
+ WebMouseEvent transformedEvent =
+ TransformWebMouseEvent(mainFrameImpl()->frameView(), event);
+ IntPoint positionInRootFrame =
+ flooredIntPoint(transformedEvent.positionInRootFrame());
// Find the right target frame. See issue 1186900.
- HitTestResult result = hitTestResultForRootFramePos(pme.position());
+ HitTestResult result = hitTestResultForRootFramePos(positionInRootFrame);
Frame* targetFrame;
if (result.innerNodeOrImageMapImage())
targetFrame = result.innerNodeOrImageMapImage()->document().frame();
@@ -577,7 +579,8 @@ void WebViewImpl::mouseContextMenu(const WebMouseEvent& event) {
{
ContextMenuAllowedScope scope;
- targetLocalFrame->eventHandler().sendContextMenuEvent(pme, nullptr);
+ targetLocalFrame->eventHandler().sendContextMenuEvent(transformedEvent,
+ nullptr);
}
// Actually showing the context menu is handled by the ContextMenuClient
// implementation...
@@ -2199,11 +2202,11 @@ WebInputEventResult WebViewImpl::handleInputEvent(
NOTREACHED();
}
- node->dispatchMouseEvent(
- PlatformMouseEventBuilder(
- mainFrameImpl()->frameView(),
- static_cast<const WebMouseEvent&>(inputEvent)),
- eventType, static_cast<const WebMouseEvent&>(inputEvent).clickCount);
+ WebMouseEvent transformedEvent =
+ TransformWebMouseEvent(mainFrameImpl()->frameView(),
+ static_cast<const WebMouseEvent&>(inputEvent));
+ node->dispatchMouseEvent(transformedEvent, eventType,
+ transformedEvent.clickCount);
return WebInputEventResult::HandledSystem;
}
@@ -4135,10 +4138,12 @@ void WebViewImpl::pointerLockMouseEvent(const WebInputEvent& event) {
const WebMouseEvent& mouseEvent = static_cast<const WebMouseEvent&>(event);
- if (page())
- page()->pointerLockController().dispatchLockedMouseEvent(
- PlatformMouseEventBuilder(mainFrameImpl()->frameView(), mouseEvent),
- eventType);
+ if (page()) {
+ WebMouseEvent transformedEvent =
+ TransformWebMouseEvent(mainFrameImpl()->frameView(), mouseEvent);
+ page()->pointerLockController().dispatchLockedMouseEvent(transformedEvent,
+ eventType);
+ }
}
void WebViewImpl::forceNextWebGLContextCreationToFail() {

Powered by Google App Engine
This is Rietveld 408576698