Remove PlatformMouseEvent and use WebMouseEvent instead

third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/RemoteFrameClientImpl.h"
 
 #include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/events/WheelEvent.h"
 #include "core/frame/RemoteFrame.h"
@@ skipping 137 matching lines @@
   // implemented, since this code path will need to be removed or refactored
   // anyway.
   // See https://crbug.com/520705.
   if (m_webFrame->toImplBase()->frame()->ownerLayoutItem().isNull())
     return;
 
   // This is only called when we have out-of-process iframes, which
   // need to forward input events across processes.
   // FIXME: Add a check for out-of-process iframes enabled.
   std::unique_ptr<WebInputEvent> webEvent;
-  if (event->isKeyboardEvent())
+  if (event->isKeyboardEvent()) {
     webEvent = WTF::wrapUnique(
         new WebKeyboardEventBuilder(*static_cast<KeyboardEvent*>(event)));
-  else if (event->isMouseEvent())
-    webEvent = WTF::wrapUnique(new WebMouseEventBuilder(
-        m_webFrame->frame()->view(),
-        m_webFrame->toImplBase()->frame()->ownerLayoutItem(),
-        *static_cast<MouseEvent*>(event)));
+  } else if (event->isMouseEvent()) {
+    MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
+    if (mouseEvent->nativeEvent()) {

[bokan, 2017/01/27 16:57:17]

So we'll only forward non-synthetic events to remote frames right? Was this the
behaviour before?

[dtapuska, 2017/01/27 21:00:00]

Reverted back to original code.

+      WebMouseEvent transformedEvent =
+          mouseEvent->nativeEvent()->flattenTransform();
+      WebFloatPoint absoluteRootFrameLocation =

[bokan, 2017/01/27 16:57:17]

You can just replace this with transformedEvent.positionInRootFrame()

[dtapuska, 2017/01/27 21:00:00]

Removed.

+          mouseEvent->nativeEvent()->positionInRootFrame();
+      IntPoint localPoint = roundedIntPoint(
+          m_webFrame->toImplBase()->frame()->ownerLayoutItem().absoluteToLocal(
+              absoluteRootFrameLocation, UseTransforms));
+      transformedEvent.x = localPoint.x();
+      transformedEvent.y = localPoint.y();
+
+      webEvent = WTF::wrapUnique(new WebMouseEvent());
+      *webEvent = transformedEvent;
+    }
+  }
 
   // Other or internal Blink events should not be forwarded.
   if (!webEvent || webEvent->type() == WebInputEvent::Undefined)
     return;
 
   m_webFrame->client()->forwardInputEvent(webEvent.get());
 }
 
 void RemoteFrameClientImpl::frameRectsChanged(const IntRect& frameRect) {
   m_webFrame->client()->frameRectsChanged(frameRect);
 }
 
 void RemoteFrameClientImpl::updateRemoteViewportIntersection(
     const IntRect& viewportIntersection) {
   m_webFrame->client()->updateRemoteViewportIntersection(viewportIntersection);
 }
 
 void RemoteFrameClientImpl::advanceFocus(WebFocusType type,
                                          LocalFrame* source) {
   m_webFrame->client()->advanceFocus(type,
                                      WebLocalFrameImpl::fromFrame(source));
 }
 
 void RemoteFrameClientImpl::visibilityChanged(bool visible) {
   m_webFrame->client()->visibilityChanged(visible);
 }
 
 }  // namespace blink