Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java

Issue 2650403004: (Android) Removing ErrorProne warnings (Closed)
Patch Set: 2nd patch version with more warnings removed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
index 2e8ab62e6f68b9e26841fb87b3ef69977bfb8bd0..0e22addef265b002d64146cbe5a5164554d44703 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
@@ -14,8 +14,6 @@ import android.content.Context;
import com.google.android.gms.gcm.GcmNetworkManager;
import com.google.android.gms.gcm.Task;
-import org.chromium.base.BaseChromiumApplication;
-import org.chromium.base.test.util.Feature;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -23,6 +21,9 @@ import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
import org.robolectric.internal.ShadowExtractor;
+import org.chromium.base.BaseChromiumApplication;
+import org.chromium.base.test.util.Feature;
+
/**
* Unit tests for BackgroundScheduler.
*/
@@ -47,9 +48,8 @@ public class BackgroundSchedulerTest {
@Test
@Feature({"OfflinePages"})
public void testSchedule() {
- BackgroundScheduler scheduler = new BackgroundScheduler();
assertNull(mGcmNetworkManager.getScheduledTask());
- scheduler.schedule(mContext, mConditions1);
+ BackgroundScheduler.schedule(mContext, mConditions1);
// Check with gcmNetworkManagerShadow that schedule got called.
assertNotNull(mGcmNetworkManager.getScheduledTask());
@@ -65,13 +65,12 @@ public class BackgroundSchedulerTest {
@Test
@Feature({"OfflinePages"})
public void testUnschedule() {
- BackgroundScheduler scheduler = new BackgroundScheduler();
assertNull(mGcmNetworkManager.getScheduledTask());
- scheduler.schedule(mContext, mConditions1);
+ BackgroundScheduler.schedule(mContext, mConditions1);
assertNotNull(mGcmNetworkManager.getScheduledTask());
assertNull(mGcmNetworkManager.getCanceledTask());
- scheduler.unschedule(mContext);
+ BackgroundScheduler.unschedule(mContext);
assertNotNull(mGcmNetworkManager.getCanceledTask());
}
}
« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698