chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java - Issue 2650403004: (Android) Removing ErrorProne warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2650403004: (Android) Removing ErrorProne warnings (Closed)

Patch Set: 2nd patch version with more warnings removed Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

index db717ad6b58ca6ae34d0bd164f2c16d25c037055..4c45823d44161d3e45d652384fb764440057c20d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

@@ -579,7 +579,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat

Intent intent = tab.getTabRedirectHandler() != null

? tab.getTabRedirectHandler().getInitialIntent() : null;

// TODO(mariakhomenko): consider also handling NDEF_DISCOVER action redirects.

- if (isIncomingRedirect && intent != null && intent.getAction() == Intent.ACTION_VIEW) {

+ if (isIncomingRedirect && intent != null && Intent.ACTION_VIEW.equals(intent.getAction())) {

// Set the URL the redirect was resolved to for checking the existence of the

// instant app inside handleIncomingIntent().

Intent resolvedIntent = new Intent(intent);