chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java - Issue 2650403004: (Android) Removing ErrorProne warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

Issue 2650403004: (Android) Removing ErrorProne warnings (Closed)

Patch Set: 2nd patch version with more warnings removed Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

index 628b54f39c7e99773634063e519f9db212d7130f..30dfc812d13ecb86e1af56c63b6b0a144f062a91 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

@@ -402,7 +402,7 @@ public class MinidumpUploadService extends IntentService {

Log.w(TAG, "Could not find a crash dump with local ID " + localId);

return;

}

- File renamedMinidumpFile = fileManager.trySetForcedUpload(minidumpFile);

+ File renamedMinidumpFile = CrashFileManager.trySetForcedUpload(minidumpFile);

if (renamedMinidumpFile == null) {

Log.w(TAG, "Could not rename the file " + minidumpFile.getName() + " for re-upload");

return;