Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/core/frame/RootFrameViewport.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Added SimTest. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RootFrameViewport.h
diff --git a/third_party/WebKit/Source/core/frame/RootFrameViewport.h b/third_party/WebKit/Source/core/frame/RootFrameViewport.h
index 5c9cb1536b9d01af83ab5563da1dee09505ea885..9fc21a0360fc5ab8fc2eede350317f5f7975b592 100644
--- a/third_party/WebKit/Source/core/frame/RootFrameViewport.h
+++ b/third_party/WebKit/Source/core/frame/RootFrameViewport.h
@@ -60,7 +60,8 @@ class CORE_EXPORT RootFrameViewport final
LayoutRect scrollIntoView(const LayoutRect& rectInContent,
const ScrollAlignment& alignX,
const ScrollAlignment& alignY,
- ScrollType = ProgrammaticScroll) override;
+ ScrollType = ProgrammaticScroll,
+ bool isSmooth = false) override;
IntRect visibleContentRect(
IncludeScrollbarsInRect = ExcludeScrollbars) const override;
bool shouldUseIntegerScrollOffset() const override;
@@ -92,6 +93,8 @@ class CORE_EXPORT RootFrameViewport final
ScrollResult userScroll(ScrollGranularity, const FloatSize&) override;
bool scrollAnimatorEnabled() const override;
HostWindow* getHostWindow() const override;
+ ProgrammaticScrollCoordinator* getProgrammaticScrollCoordinator()
+ const override;
void serviceScrollAnimations(double) override;
void updateCompositorScrollAnimations() override;
void cancelProgrammaticScrollAnimation() override;

Powered by Google App Engine
This is Rietveld 408576698