third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Added web platform test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

index 769acc39df44b05836e2d8ab1259afcd765a904f..8ba979bf160eee9cb571887c516ed564e0457e75 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

@@ -255,7 +255,8 @@ void ScrollableArea::UserScrollHelper(const ScrollOffset& offset,

LayoutRect ScrollableArea::ScrollIntoView(const LayoutRect& rect_in_content,

const ScrollAlignment& align_x,

const ScrollAlignment& align_y,

- ScrollType) {

+ ScrollType,

+ bool is_smooth) {

// TODO(bokan): This should really be implemented here but ScrollAlignment is

// in Core which is a dependency violation.

NOTREACHED();