third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Added web platform test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/RootFrameViewport.h ('K') | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

index f8a365c32b9584f2e5efabc5ac292e62cd27e0b4..e82a1a3b7964ec10ae46543fe1f50679f6d58979 100644

--- a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

+++ b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

@@ -30,7 +30,8 @@ class ProgrammaticScrollAnimator : public ScrollAnimatorCompositorCoordinator {

virtual ~ProgrammaticScrollAnimator();

void ScrollToOffsetWithoutAnimation(const ScrollOffset&);

- void AnimateToOffset(const ScrollOffset&);

+ void AnimateToOffset(const ScrollOffset&,

+ bool sequenced_for_smooth_scroll = false);

// ScrollAnimatorCompositorCoordinator implementation.

void ResetAnimationState() override;

@@ -57,6 +58,7 @@ class ProgrammaticScrollAnimator : public ScrollAnimatorCompositorCoordinator {

std::unique_ptr<CompositorScrollOffsetAnimationCurve> animation_curve_;

ScrollOffset target_offset_;

double start_time_;

+ bool sequenced_for_smooth_scroll_;

};

} // namespace blink