third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index cef8ef1a279f3757243cf20cc8e294f15cd80a5c..3dfb99073e1eb2245e80d2b1e9bb2f7bdab9e5ad 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -276,7 +276,8 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

const ScrollAlignment& alignX = ScrollAlignment::alignCenterIfNeeded,

const ScrollAlignment& alignY = ScrollAlignment::alignCenterIfNeeded,

ScrollType = ProgrammaticScroll,

- bool makeVisibleInVisualViewport = true);

+ bool makeVisibleInVisualViewport = true,

+ ScrollBehavior = ScrollBehaviorAuto);

// Convenience function for getting to the nearest enclosing box of a

// LayoutObject.