third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 6245df237f467b09253150d7f41cdc040858f773..a32dddf5daca635eb04722d176ea75f26eb89abf 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -570,7 +570,8 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

const ScrollAlignment& alignX,

const ScrollAlignment& alignY,

ScrollType = ProgrammaticScroll,

- bool makeVisibleInVisualViewport = true);

+ bool makeVisibleInVisualViewport = true,

+ ScrollBehavior = ScrollBehaviorAuto);

LayoutRectOutsets marginBoxOutsets() const override {

return m_marginBoxOutsets;