third_party/WebKit/Source/bindings/core/v8/BUILD.gn - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

index de54c3048305091a762358dd85d568d145a055a3..5bfc8df946a0700a6b08ec001cd23f50291cfa71 100644

--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

@@ -115,6 +115,8 @@ generated_core_dictionary_files = [

"$blink_core_output_dir/fileapi/BlobPropertyBag.h",

"$blink_core_output_dir/fileapi/FilePropertyBag.cpp",

"$blink_core_output_dir/fileapi/FilePropertyBag.h",

+ "$blink_core_output_dir/frame/ScrollIntoViewOptions.cpp",

+ "$blink_core_output_dir/frame/ScrollIntoViewOptions.h",

"$blink_core_output_dir/frame/ScrollOptions.cpp",

"$blink_core_output_dir/frame/ScrollOptions.h",

"$blink_core_output_dir/frame/ScrollToOptions.cpp",

@@ -182,6 +184,8 @@ bindings_core_generated_union_type_files = [

"$bindings_core_v8_output_dir/NodeOrString.h",

"$bindings_core_v8_output_dir/RadioNodeListOrElement.cpp",

"$bindings_core_v8_output_dir/RadioNodeListOrElement.h",

+ "$bindings_core_v8_output_dir/ScrollIntoViewOptionsOrBoolean.cpp",

+ "$bindings_core_v8_output_dir/ScrollIntoViewOptionsOrBoolean.h",

"$bindings_core_v8_output_dir/StringOrArrayBuffer.cpp",

"$bindings_core_v8_output_dir/StringOrArrayBuffer.h",

"$bindings_core_v8_output_dir/StringOrArrayBufferOrArrayBufferView.cpp",