Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/dom/Element.idl

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.idl
diff --git a/third_party/WebKit/Source/core/dom/Element.idl b/third_party/WebKit/Source/core/dom/Element.idl
index 07e6d7aa90489f5b14954851fb6eb6dc062b6769..cc91237af8c92fd93d9bf6ef5410db99081ea774 100644
--- a/third_party/WebKit/Source/core/dom/Element.idl
+++ b/third_party/WebKit/Source/core/dom/Element.idl
@@ -94,7 +94,7 @@ interface Element : Node {
ClientRectList getClientRects();
ClientRect getBoundingClientRect();
// FIXME: scrollIntoView() should have a ScrollIntoViewOptions dictionary argument.
- void scrollIntoView(optional boolean alignWithTop);
+ [RaisesException] void scrollIntoView(optional (ScrollIntoViewOptions or boolean)? arg);
bokan 2017/02/02 22:51:50 I don't know enough about IDL, I'd like someone wh
sunyunjia 2017/02/10 23:25:20 Acknowledged.
[RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(optional ScrollToOptions options);
[RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(unrestricted double x, unrestricted double y);
[RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(optional ScrollToOptions options);

Powered by Google App Engine
This is Rietveld 408576698