third_party/WebKit/Source/platform/geometry/FloatSize.h - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/geometry/FloatSize.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h » ('j') | third_party/WebKit/Source/platform/scroll/SmoothScrollSequencer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved.

3 * Copyright (C) 2005 Nokia. All rights reserved.	3 * Copyright (C) 2005 Nokia. All rights reserved.

4 * 2008 Eric Seidel <eric@webkit.org>	4 * 2008 Eric Seidel <eric@webkit.org>

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 181 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
192 return IntPoint(clampTo<int>(floorf(p.Width())),	192 return IntPoint(clampTo<int>(floorf(p.Width())),

193 clampTo<int>(floorf(p.Height())));	193 clampTo<int>(floorf(p.Height())));

194 }	194 }

195	195

196 // Redeclared here to avoid ODR issues.	196 // Redeclared here to avoid ODR issues.

197 // See platform/testing/GeometryPrinters.h.	197 // See platform/testing/GeometryPrinters.h.

198 void PrintTo(const FloatSize&, std::ostream*);	198 void PrintTo(const FloatSize&, std::ostream*);

199	199

200 } // namespace blink	200 } // namespace blink

201	201

	202 // Allows Oilpan to create objects with this class. See SmoothScrollSequencer.h
	jbroman 2017/05/29 19:29:47 nit: It's a vector trait thing, specifically. Also nit: It's a vector trait thing, specifically. Also the reference to SmoothScrollSequencer.h doesn't seem like it explains much more. Suggest something like "Allows this class to be stored in a HeapVector."
	203 WTF_ALLOW_CLEAR_UNUSED_SLOTS_WITH_MEM_FUNCTIONS(blink::FloatSize);

	204

202 #endif // FloatSize_h	205 #endif // FloatSize_h

OLD	NEW