Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/core/layout/ScrollAlignment.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAlignment.cpp » ('j') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // FIXME: This function should probably go somewhere else but where? 76 // FIXME: This function should probably go somewhere else but where?
77 static LayoutRect getRectToExpose(const LayoutRect& visibleRect, 77 static LayoutRect getRectToExpose(const LayoutRect& visibleRect,
78 const LayoutRect& exposeRect, 78 const LayoutRect& exposeRect,
79 const ScrollAlignment& alignX, 79 const ScrollAlignment& alignX,
80 const ScrollAlignment& alignY); 80 const ScrollAlignment& alignY);
81 81
82 static const ScrollAlignment alignCenterIfNeeded; 82 static const ScrollAlignment alignCenterIfNeeded;
83 static const ScrollAlignment alignToEdgeIfNeeded; 83 static const ScrollAlignment alignToEdgeIfNeeded;
84 static const ScrollAlignment alignCenterAlways; 84 static const ScrollAlignment alignCenterAlways;
85 static const ScrollAlignment alignClosestEdgeAlways;
85 static const ScrollAlignment alignTopAlways; 86 static const ScrollAlignment alignTopAlways;
86 static const ScrollAlignment alignBottomAlways; 87 static const ScrollAlignment alignBottomAlways;
88 static const ScrollAlignment alignLeftAlways;
89 static const ScrollAlignment alignRightAlways;
87 90
88 ScrollAlignmentBehavior m_rectVisible; 91 ScrollAlignmentBehavior m_rectVisible;
89 ScrollAlignmentBehavior m_rectHidden; 92 ScrollAlignmentBehavior m_rectHidden;
90 ScrollAlignmentBehavior m_rectPartial; 93 ScrollAlignmentBehavior m_rectPartial;
91 }; 94 };
92 95
93 } // namespace blink 96 } // namespace blink
94 97
95 #endif // ScrollAlignment_h 98 #endif // ScrollAlignment_h
OLDNEW
« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAlignment.cpp » ('j') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698