Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: ios/web_view/internal/translate/criwv_translate_manager_impl.mm

Issue 2650323002: Cleanup ios/web_view. (Closed)
Patch Set: Respond to comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/criwv_translate_manager_impl.mm
diff --git a/ios/web_view/internal/translate/criwv_translate_manager_impl.mm b/ios/web_view/internal/translate/criwv_translate_manager_impl.mm
index af0920f9677c1c425d0ba44daa98e3fb92aaeb8b..8d7f768c95a821c4f5d829035cb33f0ca6271924 100644
--- a/ios/web_view/internal/translate/criwv_translate_manager_impl.mm
+++ b/ios/web_view/internal/translate/criwv_translate_manager_impl.mm
@@ -5,23 +5,21 @@
#import "ios/web_view/internal/translate/criwv_translate_manager_impl.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_ui_delegate.h"
-@interface CRIWVTranslateManagerImpl () {
+@implementation CRIWVTranslateManagerImpl {
std::unique_ptr<translate::TranslateUIDelegate> _translateUIDelegate;
}
-@end
-
-@implementation CRIWVTranslateManagerImpl
- (instancetype)initWithTranslateManager:(translate::TranslateManager*)manager
sourceLanguage:(const std::string&)source
targetLanguage:(const std::string&)target {
if ((self = [super init])) {
DCHECK(manager);
- _translateUIDelegate.reset(new translate::TranslateUIDelegate(
- manager->GetWeakPtr(), source, target));
+ _translateUIDelegate = base::MakeUnique<translate::TranslateUIDelegate>(
+ manager->GetWeakPtr(), source, target);
}
return self;
}
« no previous file with comments | « ios/web_view/internal/translate/criwv_translate_manager_impl.h ('k') | ios/web_view/public/criwv_web_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698