Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: ios/web_view/internal/translate/criwv_translate_client.mm

Issue 2650323002: Cleanup ios/web_view. (Closed)
Patch Set: Respond to comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/criwv_translate_client.mm
diff --git a/ios/web_view/internal/translate/criwv_translate_client.mm b/ios/web_view/internal/translate/criwv_translate_client.mm
index ec44f9e7a52098277221bf4eaecc65f4913bd418..af7db4660d4dc6e4f600f0f7bb95c5eb44d8f663 100644
--- a/ios/web_view/internal/translate/criwv_translate_client.mm
+++ b/ios/web_view/internal/translate/criwv_translate_client.mm
@@ -7,6 +7,8 @@
#include <vector>
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#import "base/mac/scoped_nsobject.h"
#include "components/infobars/core/infobar.h"
#include "components/prefs/pref_service.h"
#include "components/translate/core/browser/page_translated_details.h"
@@ -30,8 +32,9 @@ namespace ios_web_view {
CRIWVTranslateClient::CRIWVTranslateClient(web::WebState* web_state)
: web::WebStateObserver(web_state),
- translate_manager_(
- new translate::TranslateManager(this, prefs::kAcceptLanguages)),
+ translate_manager_(base::MakeUnique<translate::TranslateManager>(
+ this,
+ prefs::kAcceptLanguages)),
translate_driver_(web_state,
web_state->GetNavigationManager(),
translate_manager_.get()) {}
@@ -106,9 +109,8 @@ PrefService* CRIWVTranslateClient::GetPrefs() {
std::unique_ptr<translate::TranslatePrefs>
CRIWVTranslateClient::GetTranslatePrefs() {
DCHECK(web_state());
- return std::unique_ptr<translate::TranslatePrefs>(
- new translate::TranslatePrefs(GetPrefs(), prefs::kAcceptLanguages,
- nullptr));
+ return base::MakeUnique<translate::TranslatePrefs>(
+ GetPrefs(), prefs::kAcceptLanguages, nullptr);
}
translate::TranslateAcceptLanguages*

Powered by Google App Engine
This is Rietveld 408576698