Cleanup ios/web_view.

ios/web_view/shell/shell_app_delegate.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web_view/shell/shell_app_delegate.h"
 
 #import "base/mac/scoped_nsobject.h"
 #import "ios/web_view/public/criwv.h"
 #import "ios/web_view/shell/shell_delegate.h"
 #import "ios/web_view/shell/shell_view_controller.h"
@@ skipping 31 matching lines @@
 - (void)applicationWillEnterForeground:(UIApplication*)application {
 }
 
 - (void)applicationDidBecomeActive:(UIApplication*)application {
 }
 
 - (void)applicationWillTerminate:(UIApplication*)application {
   [CRIWV shutDown];
 }
 
+- (void)dealloc {
+  [self.window release];

[sdefresne, 2017/01/25 09:11:09]

I think setting this to nil will work (since the generated setter dealloc the
old instance) and is more correct (as self.window will not point to a possibly
deallocated object).

  self.window = nil;

Or if you want to have the -release call be explicit, modify the underlying
ivar:

  [_window release];
  _window = nil;

[Eugene But (OOO till 7-30), 2017/01/25 14:28:04]

FWIW: |[self.window release];| or |self.window = nil;| is discouraged by the
style guide:
https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init...

Calling |[_window release];| is the right suggestion. I don't think |_window =
nil;| adds anything and such constructs is unusual in dealloc.
|

[michaeldo, 2017/01/25 17:23:47]

Done.

+  [super dealloc];
+}
+
 @end