Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2650253002: [Sync] Wrap model type specifics in oneof.

Created:
3 years, 11 months ago by skym
Modified:
3 years, 10 months ago
Reviewers:
bartekg
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Wrap model type specifics in oneof. BUG=687426

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M components/sync/protocol/proto_value_conversions_unittest.cc View 2 chunks +3 lines, -3 lines 1 comment Download
M components/sync/protocol/sync.proto View 1 chunk +38 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
bartekg
3 years, 11 months ago (2017-01-24 19:19:39 UTC) #6
https://codereview.chromium.org/2650253002/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_value_conversions_unittest.cc (right):

https://codereview.chromium.org/2650253002/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_value_conversions_unittest.cc:354: // TODO(skym):
Rework this case. It is no longer valid to set multiple fields.
Maybe there is a way to turn this into a parameterized test? Using lite proto
runtime makes it tricky.

One way would be to use a field id as a parameter, generate serialized protos,
parse them and discard unrecognized fields.

Powered by Google App Engine
This is Rietveld 408576698