third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h - Issue 2650183002: Remove spelling markers when element is not editable

Side by Side Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2650183002: Remove spelling markers when element is not editable (Closed)

Patch Set: Add missing comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/editing/spelling/spellcheck-remove-markers.html ('K') | « third_party/WebKit/LayoutTests/editing/spelling/spellcheck-remove-markers.html ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 void advanceToNextMisspelling(bool startBeforeSelection = false);	66 void advanceToNextMisspelling(bool startBeforeSelection = false);

67 void showSpellingGuessPanel();	67 void showSpellingGuessPanel();

68 void didBeginEditing(Element*);	68 void didBeginEditing(Element*);

69 void clearMisspellingsForMovingParagraphs(const VisibleSelection&);	69 void clearMisspellingsForMovingParagraphs(const VisibleSelection&);

70 void markMisspellingsForMovingParagraphs(const VisibleSelection&);	70 void markMisspellingsForMovingParagraphs(const VisibleSelection&);

71 void respondToChangedSelection(const Position& oldSelectionStart,	71 void respondToChangedSelection(const Position& oldSelectionStart,

72 FrameSelection::SetSelectionOptions);	72 FrameSelection::SetSelectionOptions);

73 void replaceMisspelledRange(const String&);	73 void replaceMisspelledRange(const String&);

74 void removeSpellingMarkers();	74 void removeSpellingMarkers();

75 void removeSpellingMarkersUnderWords(const Vector<String>& words);	75 void removeSpellingMarkersUnderWords(const Vector<String>& words);

	76 enum ElementsType { All, OnlyNonEditable };
	Xiaocheng 2017/02/01 05:20:28 Please use \|enum class\|, and name the members in k Please use \|enum class\|, and name the members in kCamelCase style. Forgot the link to the coding style reference, which yosin@ sent when reviewing my patches several times... Manuel Rego 2017/02/01 14:50:25 Acknowledged. Show quoted text On 2017/02/01 05:20:28, Xiaocheng wrote: > Please use \|enum class\|, and name the members in kCamelCase style. > > Forgot the link to the coding style reference, which yosin@ sent when reviewing > my patches several times... Acknowledged.
	77 void removeSpellingAndGrammarMarkers(const HTMLElement&, ElementsType = All);

76 void spellCheckAfterBlur();	78 void spellCheckAfterBlur();

77	79

78 void didEndEditingOnTextField(Element*);	80 void didEndEditingOnTextField(Element*);

79 bool selectionStartHasMarkerFor(DocumentMarker::MarkerType,	81 bool selectionStartHasMarkerFor(DocumentMarker::MarkerType,

80 int from,	82 int from,

81 int length) const;	83 int length) const;

82 bool selectionStartHasSpellingMarkerFor(int from, int length) const;	84 bool selectionStartHasSpellingMarkerFor(int from, int length) const;

83 void updateMarkersForWordsAffectedByEditing(	85 void updateMarkersForWordsAffectedByEditing(

84 bool onlyHandleWordsContainingSelection);	86 bool onlyHandleWordsContainingSelection);

85 void cancelCheck();	87 void cancelCheck();

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126 Member<LocalFrame> m_frame;	128 Member<LocalFrame> m_frame;

127	129

128 // TODO(xiaochengh): Move it to IdleSpellCheckCallback after idle time spell	130 // TODO(xiaochengh): Move it to IdleSpellCheckCallback after idle time spell

129 // checking reaches status=stable.	131 // checking reaches status=stable.

130 const Member<SpellCheckRequester> m_spellCheckRequester;	132 const Member<SpellCheckRequester> m_spellCheckRequester;

131 };	133 };

132	134

133 } // namespace blink	135 } // namespace blink

134	136

135 #endif // SpellChecker_h	137 #endif // SpellChecker_h

OLD	NEW