Remove spelling markers when element is not editable

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 784 matching lines @@
 
 void SpellChecker::didEndEditingOnTextField(Element* e) {
   TRACE_EVENT0("blink", "SpellChecker::didEndEditingOnTextField");
 
   // Remove markers when deactivating a selection in an <input type="text"/>.
   // Prevent new ones from appearing too.
   if (!RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
     m_spellCheckRequester->cancelCheck();
   TextControlElement* textControlElement = toTextControlElement(e);
   HTMLElement* innerEditor = textControlElement->innerEditorElement();
+  removeSpellingAndGrammarMarkers(*innerEditor);
+}
+
+void SpellChecker::removeSpellingAndGrammarMarkers(HTMLElement& element) {

[yosin_UTC9, 2017/01/26 04:55:48]

Note: We want to make this function to have |const HTMLElement&|, but 
|DocumentMarkerController::removeMarkers()| takes |Node*| incorrectly.

   DocumentMarker::MarkerTypes markerTypes(DocumentMarker::Spelling);
   markerTypes.add(DocumentMarker::Grammar);
-  for (Node& node : NodeTraversal::inclusiveDescendantsOf(*innerEditor))
+  for (Node& node : NodeTraversal::inclusiveDescendantsOf(element))

[Xiaocheng, 2017/01/26 05:12:33]

This function still removes all markers from the entire subtree, which means it
still doesn't pass the test case I previously gave.

We should remove markers only from non-editable elements.

[yosin_UTC9, 2017/01/26 05:44:02]

Let me cancel my "lgtm". We need to support following scenario:

<div id="outer" contenteditable>foo<div id="innner"
contenteditable>bar</div>baz</div>

When outer.setAttribute('contenteditable', 'false'), we should keep document
marker for "inner".

[Manuel Rego, 2017/01/27 12:56:19]

True, sorry about that. I was checking only one thing,
removing "contenteditable" from "child",
but not the other option, removing it from "parent".
E.g.
  <div contenteditable id="parent">
    zz.
    <div contenteditable id="child">zz.</div>
    zz.
  </div>

     frame().document()->markers().removeMarkers(&node, markerTypes);
 }
 
 void SpellChecker::replaceMisspelledRange(const String& text) {
   EphemeralRange caretRange =
       frame().selection().selection().toNormalizedEphemeralRange();
   if (caretRange.isNull())
     return;
   DocumentMarkerVector markers = frame().document()->markers().markersInRange(
       caretRange, DocumentMarker::MisspellingMarkers());
@@ skipping 349 matching lines @@
         startOfNextParagraph(createVisiblePosition(paragraphEnd));
     paragraphStart = newParagraphStart.toParentAnchoredPosition();
     paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
     firstIteration = false;
     totalLengthProcessed += currentLength;
   }
   return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 }  // namespace blink