Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: base/path_service.cc

Issue 265013002: Revert of Enable Enterprise enrollment on desktop builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/path_service.h ('k') | base/path_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/path_service.h" 5 #include "base/path_service.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 226
227 base::AutoLock scoped_lock(path_data->lock); 227 base::AutoLock scoped_lock(path_data->lock);
228 if (!path_data->cache_disabled) 228 if (!path_data->cache_disabled)
229 path_data->cache[key] = path; 229 path_data->cache[key] = path;
230 230
231 return true; 231 return true;
232 } 232 }
233 233
234 // static 234 // static
235 bool PathService::Override(int key, const FilePath& path) { 235 bool PathService::Override(int key, const FilePath& path) {
236 // Just call the full function with true for the value of |create|, and 236 // Just call the full function with true for the value of |create|.
237 // assume that |path| may not be absolute yet. 237 return OverrideAndCreateIfNeeded(key, path, true);
238 return OverrideAndCreateIfNeeded(key, path, false, true);
239 } 238 }
240 239
241 // static 240 // static
242 bool PathService::OverrideAndCreateIfNeeded(int key, 241 bool PathService::OverrideAndCreateIfNeeded(int key,
243 const FilePath& path, 242 const FilePath& path,
244 bool is_absolute,
245 bool create) { 243 bool create) {
246 PathData* path_data = GetPathData(); 244 PathData* path_data = GetPathData();
247 DCHECK(path_data); 245 DCHECK(path_data);
248 DCHECK_GT(key, base::DIR_CURRENT) << "invalid path key"; 246 DCHECK_GT(key, base::DIR_CURRENT) << "invalid path key";
249 247
250 FilePath file_path = path; 248 FilePath file_path = path;
251 249
252 // For some locations this will fail if called from inside the sandbox there- 250 // For some locations this will fail if called from inside the sandbox there-
253 // fore we protect this call with a flag. 251 // fore we protect this call with a flag.
254 if (create) { 252 if (create) {
255 // Make sure the directory exists. We need to do this before we translate 253 // Make sure the directory exists. We need to do this before we translate
256 // this to the absolute path because on POSIX, MakeAbsoluteFilePath fails 254 // this to the absolute path because on POSIX, MakeAbsoluteFilePath fails
257 // if called on a non-existent path. 255 // if called on a non-existent path.
258 if (!base::PathExists(file_path) && 256 if (!base::PathExists(file_path) &&
259 !base::CreateDirectory(file_path)) 257 !base::CreateDirectory(file_path))
260 return false; 258 return false;
261 } 259 }
262 260
263 // We need to have an absolute path. 261 // We need to have an absolute path.
264 if (!is_absolute) { 262 file_path = MakeAbsoluteFilePath(file_path);
265 file_path = MakeAbsoluteFilePath(file_path); 263 if (file_path.empty())
266 if (file_path.empty()) 264 return false;
267 return false;
268 }
269 DCHECK(file_path.IsAbsolute());
270 265
271 base::AutoLock scoped_lock(path_data->lock); 266 base::AutoLock scoped_lock(path_data->lock);
272 267
273 // Clear the cache now. Some of its entries could have depended 268 // Clear the cache now. Some of its entries could have depended
274 // on the value we are overriding, and are now out of sync with reality. 269 // on the value we are overriding, and are now out of sync with reality.
275 path_data->cache.clear(); 270 path_data->cache.clear();
276 271
277 path_data->overrides[key] = file_path; 272 path_data->overrides[key] = file_path;
278 273
279 return true; 274 return true;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 327
333 // static 328 // static
334 void PathService::DisableCache() { 329 void PathService::DisableCache() {
335 PathData* path_data = GetPathData(); 330 PathData* path_data = GetPathData();
336 DCHECK(path_data); 331 DCHECK(path_data);
337 332
338 base::AutoLock scoped_lock(path_data->lock); 333 base::AutoLock scoped_lock(path_data->lock);
339 path_data->cache.clear(); 334 path_data->cache.clear();
340 path_data->cache_disabled = true; 335 path_data->cache_disabled = true;
341 } 336 }
OLDNEW
« no previous file with comments | « base/path_service.h ('k') | base/path_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698