Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 265013002: Revert of Enable Enterprise enrollment on desktop builds. (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert of Enable Enterprise enrollment on desktop builds. (https://codereview.chromium.org/258743005/) Reason for revert: It seems to have broken the following test from base_unittests and unit_tests on chromium.webkit Android Tests (dbg) builder: PathServiceTest.Override Log: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18922 Snippet from log: C 237s Main [FAIL] PathServiceTest.Override: C 237s Main ../../base/path_service_unittest.cc:184: Failure C 237s Main Value of: PathService::OverrideAndCreateIfNeeded(my_special_key, non_existent, false, false) C 237s Main Actual: true C 237s Main Expected: false Original issue's description: > Enable Enterprise enrollment on desktop builds. > > This change implements some of the DBus stub methods so that enterprise enrollment works on desktop builds. That will make development of features that depend on enrollment faster for developers that use this workflow (e.g. for kiosk enterprise apps, public accounts, testing some device policies, etc). > > - Override some of the directories and files involved with the enrollment state > - Simple stub implementation of the DBus calls involved > - Write a persistent cache of the install attributes > - Cleaned up the stub for user cloud policy and made them persistent too > - Updated some tests > > This change doesn't affect production code. > > TBR=jochen@chromium.org > BUG=240269, 367674 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267640 TBR=brettw@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,satorux@chromium.org,jochen@chromium.org,joaodasilva@chromium.org NOTREECHECKS=true NOTRY=true BUG=240269, 367674 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -465 lines) Patch
M base/path_service.h View 1 chunk +2 lines, -9 lines 0 comments Download
M base/path_service.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M base/path_service_unittest.cc View 2 chunks +1 line, -26 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 4 chunks +9 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 10 chunks +72 lines, -105 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chromeos/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_paths.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chromeos/chromeos_paths.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 3 chunks +2 lines, -73 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 6 chunks +41 lines, -98 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/policy.gypi View 4 chunks +2 lines, -12 lines 0 comments Download
D components/policy/policy_proto_export.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
falken
Created Revert of Enable Enterprise enrollment on desktop builds.
6 years, 7 months ago (2014-05-02 05:22:21 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-05-02 05:27:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/265013002/1
6 years, 7 months ago (2014-05-02 05:27:36 UTC) #3
satorux1
On 2014/05/02 05:27:36, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 7 months ago (2014-05-02 05:28:45 UTC) #4
falken
On 2014/05/02 05:28:45, satorux1 wrote: > On 2014/05/02 05:27:36, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-02 05:31:48 UTC) #5
commit-bot: I haz the power
Change committed as 267761
6 years, 7 months ago (2014-05-02 05:39:04 UTC) #6
satorux1
On 2014/05/02 05:31:48, falken wrote: > On 2014/05/02 05:28:45, satorux1 wrote: > > On 2014/05/02 ...
6 years, 7 months ago (2014-05-02 05:50:02 UTC) #7
Joao da Silva
6 years, 7 months ago (2014-05-02 08:13:03 UTC) #8
Message was sent while issue was closed.
Turns out that an earlier version of Bionic libc doesn't correctly implement
realpath():

  http://www.netmite.com/android/mydroid/bionic/libc/bionic/realpath.c

Note that that implementation doesn't fail if lstat() on the last component of
the path fails. I'll prepare a fix.

Powered by Google App Engine
This is Rietveld 408576698