Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 2650113005: Convert NavigationTracingObserver to use the new navigation callbacks. (Closed)
Patch Set: review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tracing/navigation_tracing.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tracing/navigation_tracing.cc
diff --git a/chrome/browser/tracing/navigation_tracing.cc b/chrome/browser/tracing/navigation_tracing.cc
index e5c7332abe91b4b9ead83dd5fc91af70c5faf795..510b6e9df5feaa8f4c95b5957e31a427f1ee37af 100644
--- a/chrome/browser/tracing/navigation_tracing.cc
+++ b/chrome/browser/tracing/navigation_tracing.cc
@@ -15,6 +15,7 @@
#include "content/public/browser/background_tracing_config.h"
#include "content/public/browser/background_tracing_manager.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
DEFINE_WEB_CONTENTS_USER_DATA_KEY(tracing::NavigationTracingObserver);
@@ -101,8 +102,8 @@ bool NavigationTracingObserver::IsEnabled() {
NavigationTracingObserver::NavigationTracingObserver(
content::WebContents* web_contents)
: content::WebContentsObserver(web_contents) {
- if (navigation_handle == -1) {
- navigation_handle =
+ if (navigation_trigger_handle_ == -1) {
+ navigation_trigger_handle_ =
content::BackgroundTracingManager::GetInstance()->RegisterTriggerType(
kNavigationTracingConfig);
}
@@ -111,18 +112,16 @@ NavigationTracingObserver::NavigationTracingObserver(
NavigationTracingObserver::~NavigationTracingObserver() {
}
-void NavigationTracingObserver::DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page) {
- if (!render_frame_host->GetParent() && !is_error_page) {
+void NavigationTracingObserver::DidStartNavigation(
+ content::NavigationHandle* navigation_handle) {
+ if (navigation_handle->IsInMainFrame()) {
content::BackgroundTracingManager::GetInstance()->TriggerNamedEvent(
- navigation_handle,
+ navigation_trigger_handle_,
content::BackgroundTracingManager::StartedFinalizingCallback());
}
}
content::BackgroundTracingManager::TriggerHandle
- NavigationTracingObserver::navigation_handle = -1;
+ NavigationTracingObserver::navigation_trigger_handle_ = -1;
} // namespace tracing
« no previous file with comments | « chrome/browser/tracing/navigation_tracing.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698