Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/tracing/navigation_tracing.h

Issue 2650113005: Convert NavigationTracingObserver to use the new navigation callbacks. (Closed)
Patch Set: use trailing underscore per style guide to avoid name clash Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tracing/navigation_tracing.h
diff --git a/chrome/browser/tracing/navigation_tracing.h b/chrome/browser/tracing/navigation_tracing.h
index f26287e5185b58fdc667612bb5cbc0f3723bbd61..cfe0e0e5e8db6d438312af71af1556e2e4a43920 100644
--- a/chrome/browser/tracing/navigation_tracing.h
+++ b/chrome/browser/tracing/navigation_tracing.h
@@ -28,12 +28,10 @@ class NavigationTracingObserver
~NavigationTracingObserver() override;
// content::WebContentsObserver implementation.
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page) override;
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
- static content::BackgroundTracingManager::TriggerHandle navigation_handle;
+ static content::BackgroundTracingManager::TriggerHandle navigation_handle_;
fmeawad 2017/01/26 15:44:37 I think we should rename navigation_handle_ to nav
jam 2017/01/26 16:33:35 Done.
DISALLOW_COPY_AND_ASSIGN(NavigationTracingObserver);
};
« no previous file with comments | « no previous file | chrome/browser/tracing/navigation_tracing.cc » ('j') | chrome/browser/tracing/navigation_tracing.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698