Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Remove logging statements, fix copyright years in new files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index b798e6497b6c6ec9635e814ffef0eaf72d7b1754..0d50481c702903893b725d157dfa49dd3554c967 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -43,6 +43,7 @@
#include "core/frame/Settings.h"
#include "core/layout/LayoutView.h"
#include "core/layout/api/LayoutViewItem.h"
+#include "core/page/ChromeClient.h"
#include "core/page/FocusController.h"
#include "core/page/Page.h"
#include "platform/RuntimeEnabledFeatures.h"
@@ -258,8 +259,12 @@ bool SelectionController::handleMousePressEventSingleClick(
SelectionInFlatTree::Builder()
.collapse(visiblePos.toPositionWithAffinity())
.build())),
- CharacterGranularity, isHandleVisible ? HandleVisibility::Visible
- : HandleVisibility::NotVisible);
+ CharacterGranularity,
+ isHandleVisible ? HandleVisibility::Visible
+ : HandleVisibility::NotVisible);
+
+ document().page()->chromeClient().handlePotentialTextSuggestionTap();
+
return false;
}

Powered by Google App Engine
This is Rietveld 408576698