Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
index d31d2ecc93bad0d4d442464510f362cee61074a4..136c39c97bffd65511100c859870efdf859c8b0f 100644
--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
@@ -134,6 +134,21 @@ bool WebInputMethodControllerImpl::commitText(
relativeCaretPosition);
}
+void WebInputMethodControllerImpl::applySuggestionReplacement(
+ int documentMarkerID,
+ int suggestionIndex) {
+ inputMethodController().applySuggestionReplacement(documentMarkerID,
+ suggestionIndex);
+}
+
+void WebInputMethodControllerImpl::deleteSuggestionHighlight() {
+ inputMethodController().deleteSuggestionHighlight();
+}
+
+void WebInputMethodControllerImpl::closeSuggestionMenu() {
+ inputMethodController().closeSuggestionMenu();
+}
+
WebTextInputInfo WebInputMethodControllerImpl::textInputInfo() {
return frame()->inputMethodController().textInputInfo();
}
@@ -142,6 +157,17 @@ WebTextInputType WebInputMethodControllerImpl::textInputType() {
return frame()->inputMethodController().textInputType();
}
+WebVector<WebTextSuggestionInfo>
+WebInputMethodControllerImpl::getTextSuggestionInfosUnderCaret() {
+ return frame()->inputMethodController().getTextSuggestionInfosUnderCaret();
+}
+
+void WebInputMethodControllerImpl::prepareForTextSuggestionMenuToBeShown() {
aelias_OOO_until_Jul13 2017/01/25 03:34:27 This seems to have no callers?
rlanday 2017/01/25 18:48:10 Oh, I think I should add a call somewhere because
+ return frame()
+ ->inputMethodController()
+ .prepareForTextSuggestionMenuToBeShown();
+}
+
LocalFrame* WebInputMethodControllerImpl::frame() const {
return m_webLocalFrame->frame();
}

Powered by Google App Engine
This is Rietveld 408576698