[WIP] Add support for Android SuggestionSpans when editing text

third_party/WebKit/Source/core/dom/CharacterData.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2013 Apple Inc. All
  * rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 136 matching lines @@
   if (!validateOffsetCount(offset, count, length(), realCount, exceptionState))
     return;
 
   String newStr = m_data;
   newStr.remove(offset, realCount);
   newStr.insert(data, offset);
 
   setDataAndUpdate(newStr, offset, realCount, data.length(),
                    UpdateFromNonParser);
 
-  // update the markers for spell checking and grammar checking
-  document().didRemoveText(this, offset, realCount);
+  // Update the markers for spell checking, grammar checking, and text
+  // suggestions. didInsertText() must be called first so suggestion markers
+  // properly track text replacments.
   document().didInsertText(this, offset, data.length());
+  document().didRemoveText(this, offset + data.length(), realCount);

[rlanday, 2017/01/31 19:50:21]

I hope this doesn't break anything...presumably we have test cases that would
catch if this messes up DOM range handling, and I don't think any of the other
DocumentMarker types persist long enough for this to be an issue...

[esprehn, 2017/01/31 22:41:34]

This probably needs unit tests?

 }
 
 String CharacterData::nodeValue() const {
   return m_data;
 }
 
 bool CharacterData::containsOnlyWhitespace() const {
   return m_data.containsOnlyWhitespace();
 }
 
@@ skipping 52 matching lines @@
     dispatchSubtreeModifiedEvent();
   }
   InspectorInstrumentation::characterDataModified(this);
 }
 
 int CharacterData::maxCharacterOffset() const {
   return static_cast<int>(length());
 }
 
 }  // namespace blink