content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml - Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)

Patch Set: Remove logging statements, fix copyright years in new files Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/res/drawable/floating_popup_background_light.xml ('k') | content/public/android/java/res/layout-v21/text_edit_suggestion_item.xml » ('j') | content/public/android/java/src/org/chromium/content/browser/input/SuggestionInfo.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->
	rlanday 2017/01/31 19:50:21 It seems we use inconsistent styles for these comm It seems we use inconsistent styles for these comment headers...is the --> supposed to be on its own line, or on the previous line?
	6

	7 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:tools="http://schemas.android.com/tools"

	9 android:layout_width="wrap_content"

	10 android:layout_height="wrap_content">

	11 <LinearLayout

	12 android:id="@+id/suggestionWindowContainer"

	13 android:layout_width="match_parent"

	14 android:layout_height="wrap_content"

	15 android:background="@drawable/floating_popup_background_light"

	16 android:elevation="2dp"

	17 android:layout_margin="20dp"

	18 android:orientation="vertical"

	19 android:divider="?android:attr/listDivider"

	20 android:showDividers="middle"

	21 tools:ignore="UselessParent">

	22 <ListView

	23 android:id="@+id/suggestionContainer"

	24 android:layout_width="match_parent"

	25 android:layout_height="wrap_content"

	26 android:paddingTop="4dp"

	27 android:paddingBottom="0dp"

	28 android:divider="@null" />

	29 <LinearLayout

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:orientation="vertical">

	33 <TextView

	34 android:id="@+id/deleteButton"

	35 android:text="@string/delete_text"

	36 android:textAppearance="@android:style/TextAppearance.Material.But ton"

	37 android:textColor="?@android:attr/colorAccent"

	38 android:drawablePadding="8dip"

	39 android:gravity="start\|center_vertical"

	40 android:layout_gravity="start\|center_vertical"

	41 android:layout_height="48dip"

	42 android:layout_width="match_parent"

	43 android:paddingBottom="8dip"

	44 android:paddingEnd="16dip"

	45 android:paddingStart="16dip"

	46 android:paddingTop="8dip"

	47 android:singleLine="true"

	48 android:textAllCaps="true"

	49 android:textSize="14sp" />

	50 </LinearLayout>

	51 </LinearLayout>

	52 </RelativeLayout>

OLD	NEW