Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/input/render_widget_input_handler.h" 5 #include "content/renderer/input/render_widget_input_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 ->DidHandleInputEventOnMainThread(input_event); 413 ->DidHandleInputEventOnMainThread(input_event);
414 } 414 }
415 415
416 #if defined(OS_ANDROID) 416 #if defined(OS_ANDROID)
417 // Allow the IME to be shown when the focus changes as a consequence 417 // Allow the IME to be shown when the focus changes as a consequence
418 // of a processed touch end event. 418 // of a processed touch end event.
419 if (input_event.type() == WebInputEvent::TouchEnd && 419 if (input_event.type() == WebInputEvent::TouchEnd &&
420 processed != WebInputEventResult::NotHandled) { 420 processed != WebInputEventResult::NotHandled) {
421 delegate_->ShowVirtualKeyboard(); 421 delegate_->ShowVirtualKeyboard();
422 } 422 }
423
424 if (input_event.type() == WebInputEvent::GestureTap) {
aelias_OOO_until_Jul13 2017/01/25 03:34:26 This handler is too generica place to put this, pl
rlanday 2017/01/26 01:29:07 That would be SelectionController::handleMousePres
aelias_OOO_until_Jul13 2017/01/26 02:00:30 You can just add a new abstract method in third_pa
425 delegate_->HandlePotentialTextSuggestionTap();
426 }
423 #elif defined(USE_AURA) 427 #elif defined(USE_AURA)
424 // Show the virtual keyboard if enabled and a user gesture triggers a focus 428 // Show the virtual keyboard if enabled and a user gesture triggers a focus
425 // change. 429 // change.
426 if (processed != WebInputEventResult::NotHandled && 430 if (processed != WebInputEventResult::NotHandled &&
427 (input_event.type() == WebInputEvent::TouchEnd || 431 (input_event.type() == WebInputEvent::TouchEnd ||
428 input_event.type() == WebInputEvent::MouseUp)) { 432 input_event.type() == WebInputEvent::MouseUp)) {
429 delegate_->ShowVirtualKeyboard(); 433 delegate_->ShowVirtualKeyboard();
430 } 434 }
431 #endif 435 #endif
432 436
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 // it can be bundled in the event ack. 468 // it can be bundled in the event ack.
465 if (handling_event_overscroll_) { 469 if (handling_event_overscroll_) {
466 *handling_event_overscroll_ = std::move(params); 470 *handling_event_overscroll_ = std::move(params);
467 return; 471 return;
468 } 472 }
469 473
470 delegate_->OnDidOverscroll(*params); 474 delegate_->OnDidOverscroll(*params);
471 } 475 }
472 476
473 } // namespace content 477 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698