[WIP] Add support for Android SuggestionSpans when editing text

content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.annotation.TargetApi;
 import android.graphics.Matrix;
 import android.os.Build;
 import android.view.View;
@@ skipping 63 matching lines @@
     @Nonnull
     private final CursorAnchorInfo.Builder mCursorAnchorInfoBuilder =
             new CursorAnchorInfo.Builder();
 
     @Nullable
     private InputMethodManagerWrapper mInputMethodManagerWrapper;
     @Nullable
     private final ComposingTextDelegate mComposingTextDelegate;
     @Nonnull
     private final ViewDelegate mViewDelegate;
+    @Nullable
+    private final ImeAdapter mImeAdapter;
 
     private CursorAnchorInfoController(InputMethodManagerWrapper inputMethodManagerWrapper,
-            ComposingTextDelegate composingTextDelegate, ViewDelegate viewDelegate) {
+            ComposingTextDelegate composingTextDelegate, ViewDelegate viewDelegate,
+            ImeAdapter imeAdapter) {
         mInputMethodManagerWrapper = inputMethodManagerWrapper;
         mComposingTextDelegate = composingTextDelegate;
         mViewDelegate = viewDelegate;
+        mImeAdapter = imeAdapter;
     }
 
     public static CursorAnchorInfoController create(
             InputMethodManagerWrapper inputMethodManagerWrapper,
-            ComposingTextDelegate composingTextDelegate) {
-        return new CursorAnchorInfoController(inputMethodManagerWrapper,
-                composingTextDelegate, new ViewDelegate() {
+            ComposingTextDelegate composingTextDelegate, ImeAdapter imeAdapter) {
+        return new CursorAnchorInfoController(
+                inputMethodManagerWrapper, composingTextDelegate, new ViewDelegate() {
                     @Override
                     public void getLocationOnScreen(View view, int[] location) {
                         view.getLocationOnScreen(location);
                     }
-                });
+                }, imeAdapter);
     }
 
     @VisibleForTesting
     public void setInputMethodManagerWrapperForTest(
             InputMethodManagerWrapper inputMethodManagerWrapper) {
         mInputMethodManagerWrapper = inputMethodManagerWrapper;
     }
 
     @VisibleForTesting
     public static CursorAnchorInfoController createForTest(
             InputMethodManagerWrapper inputMethodManagerWrapper,
-            ComposingTextDelegate composingTextDelegate,
-            ViewDelegate viewDelegate) {
-        return new CursorAnchorInfoController(inputMethodManagerWrapper, composingTextDelegate,
-                viewDelegate);
+            ComposingTextDelegate composingTextDelegate, ViewDelegate viewDelegate,
+            ImeAdapter imeAdapter) {
+        return new CursorAnchorInfoController(
+                inputMethodManagerWrapper, composingTextDelegate, viewDelegate, imeAdapter);
     }
 
     /**
      * Called by ImeAdapter when a IME related web content state is changed.
      */
     public void invalidateLastCursorAnchorInfo() {
         if (!mIsEditable) return;
 
         mLastCursorAnchorInfo = null;
     }
@@ skipping 59 matching lines @@
             mScale = scale;
             mTranslationX = translationX;
             mTranslationY = translationY;
             mHasInsertionMarker = hasInsertionMarker;
             mIsInsertionMarkerVisible = isInsertionMarkerVisible;
             mInsertionMarkerHorizontal = insertionMarkerHorizontal;
             mInsertionMarkerTop = insertionMarkerTop;
             mInsertionMarkerBottom = insertionMarkerBottom;
         }
 
-        // Notify to IME if there is a pending request, or if it is in monitor mode and we have
-        // some change in the state.
-        if (mHasPendingImmediateRequest

[aelias_OOO_until_Jul13, 2017/01/25 03:34:26]

These conditions are important to preserve for performance reasons.  You might
want to turn on "monitor mode" at any time a SuggestionSpan is present, or
(perhaps better) send an "immediate request" at time of creating the menu.

[rlanday, 2017/01/25 19:21:56]

I think we probably want to turn on "monitor mode" when the menu is open? That
way we can keep the menu positioned properly, but we don't need to request any
updates just because a SuggestionSpan is present.

-                || (mMonitorModeEnabled && mLastCursorAnchorInfo == null)) {
-            updateCursorAnchorInfo(view);
-        }
+        // Notify ImeAdapter
+        updateCursorAnchorInfo(view);
     }
 
     public void focusedNodeChanged(boolean isEditable) {
         mIsEditable = isEditable;
         mCompositionCharacterBounds = null;
         mHasCoordinateInfo = false;
         mLastCursorAnchorInfo = null;
     }
 
     public boolean onRequestCursorUpdates(boolean immediateRequest, boolean monitorRequest,
@@ skipping 58 matching lines @@
                         mInsertionMarkerBottom,
                         mIsInsertionMarkerVisible ? CursorAnchorInfo.FLAG_HAS_VISIBLE_REGION :
                                 CursorAnchorInfo.FLAG_HAS_INVISIBLE_REGION);
             }
             mLastCursorAnchorInfo = mCursorAnchorInfoBuilder.build();
         }
 
         if (mInputMethodManagerWrapper != null) {
             mInputMethodManagerWrapper.updateCursorAnchorInfo(view, mLastCursorAnchorInfo);
         }
+        if (mImeAdapter != null) {
+            mImeAdapter.updateCursorAnchorInfo(view, mLastCursorAnchorInfo);
+        }
         mHasPendingImmediateRequest = false;
     }
 }