[WIP] Add support for Android SuggestionSpans when editing text

content/common/input_messages.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for input events and other messages that require processing in
 // order relative to input events.
 // Multiply-included message file, hence no include guard.
 
 #include "base/strings/string16.h"
 #include "build/build_config.h"
@@ skipping 10 matching lines @@
 #include "content/common/input/synthetic_gesture_params.h"
 #include "content/common/input/synthetic_pinch_gesture_params.h"
 #include "content/common/input/synthetic_pointer_action_list_params.h"
 #include "content/common/input/synthetic_pointer_action_params.h"
 #include "content/common/input/synthetic_smooth_drag_gesture_params.h"
 #include "content/common/input/synthetic_smooth_scroll_gesture_params.h"
 #include "content/common/input/synthetic_tap_gesture_params.h"
 #include "content/common/input/touch_action.h"
 #include "ipc/ipc_message_macros.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
+#include "third_party/WebKit/public/web/WebTextSuggestionInfo.h"
 #include "ui/events/blink/did_overscroll_params.h"
 #include "ui/events/ipc/latency_info_param_traits.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/vector2d_f.h"
 #include "ui/gfx/ipc/gfx_param_traits.h"
 #include "ui/gfx/ipc/skia/gfx_skia_param_traits.h"
 #include "ui/gfx/range/range.h"
 
 #undef IPC_MESSAGE_EXPORT
@@ skipping 87 matching lines @@
 
 IPC_STRUCT_TRAITS_BEGIN(content::InputEventAck)
   IPC_STRUCT_TRAITS_MEMBER(source)
   IPC_STRUCT_TRAITS_MEMBER(type)
   IPC_STRUCT_TRAITS_MEMBER(state)
   IPC_STRUCT_TRAITS_MEMBER(latency)
   IPC_STRUCT_TRAITS_MEMBER(overscroll)
   IPC_STRUCT_TRAITS_MEMBER(unique_touch_event_id)
 IPC_STRUCT_TRAITS_END()
 
+IPC_STRUCT_TRAITS_BEGIN(blink::WebTextSuggestionInfo)
+  IPC_STRUCT_TRAITS_MEMBER(documentMarkerID)
+  IPC_STRUCT_TRAITS_MEMBER(suggestionStart)
+  IPC_STRUCT_TRAITS_MEMBER(suggestionEnd)
+  IPC_STRUCT_TRAITS_MEMBER(spanStart)
+  IPC_STRUCT_TRAITS_MEMBER(spanEnd)
+  IPC_STRUCT_TRAITS_MEMBER(suggestionIndex)
+  IPC_STRUCT_TRAITS_MEMBER(prefix)
+  IPC_STRUCT_TRAITS_MEMBER(suggestion)
+  IPC_STRUCT_TRAITS_MEMBER(suffix)
+IPC_STRUCT_TRAITS_END()
+
 // Sends an input event to the render widget. The input event in general
 // contains a list of coalesced events and one event that is representative of
 // all those events (https://w3c.github.io/pointerevents/extension.html).
 IPC_MESSAGE_ROUTED4(
     InputMsg_HandleInputEvent,
     IPC::WebInputEventPointer /* event */,
     std::vector<IPC::WebInputEventPointer> /* coalesced events */,
     ui::LatencyInfo /* latency_info */,
     content::InputEventDispatchType)
 
@@ skipping 28 matching lines @@
 
 // This message sends a string being composed with an input method.
 IPC_MESSAGE_ROUTED5(
     InputMsg_ImeSetComposition,
     base::string16, /* text */
     std::vector<blink::WebCompositionUnderline>, /* underlines */
     gfx::Range /* replacement_range */,
     int, /* selectiont_start */
     int /* selection_end */)
 
+IPC_MESSAGE_ROUTED2(InputMsg_ImeApplySuggestionReplacement,

[aelias_OOO_until_Jul13, 2017/01/25 03:34:26]

These do not originate from the IME per se so I'd prefer "Ime" not be in the
name.

+                    int /* document_marker_ID */,
+                    int /* suggestion_index */)
+
+IPC_MESSAGE_ROUTED0(InputMsg_ImeDeleteSuggestionHighlight)

[aelias_OOO_until_Jul13, 2017/01/25 03:34:26]

Can this take a marker ID as well instead of inferring it from current
selection?  Or, if the ID doesn't provide any information on top of what Blink
has to keep state on anyway, I guess neither message should have it.

[rlanday, 2017/01/25 18:48:10]

This message doesn't take an ID because:
  - At any point there's only one span of text highlighted in this manner
  - The highlighted span is actually a union of SuggestionSpan ranges rather
than necessarily corresponding to any individual range

The messages to replace an individual SuggestionSpan do need the ID because
neither of these two reasons applies.

+
+IPC_MESSAGE_ROUTED0(InputMsg_ImeCloseSuggestionMenu)

[aelias_OOO_until_Jul13, 2017/01/25 03:34:26]

This is more of a notification for something that already happened, so I'd
prefer "InputMsg_SuggestionMenuClosed"

+
 // This message deletes the current composition, inserts specified text, and
 // moves the cursor.
 IPC_MESSAGE_ROUTED4(
     InputMsg_ImeCommitText,
     base::string16 /* text */,
     std::vector<blink::WebCompositionUnderline>, /* underlines */
     gfx::Range /* replacement_range */,
     int /* relative_cursor_pos */)
 
 // This message inserts the ongoing composition.
@@ skipping 124 matching lines @@
 
 // Required for cancelling an ongoing input method composition.
 IPC_MESSAGE_ROUTED0(InputHostMsg_ImeCancelComposition)
 
 // This IPC message sends the character bounds after every composition change
 // to always have correct bound info.
 IPC_MESSAGE_ROUTED2(InputHostMsg_ImeCompositionRangeChanged,
                     gfx::Range /* composition range */,
                     std::vector<gfx::Rect> /* character bounds */)
 
+IPC_MESSAGE_ROUTED1(InputHostMsg_ShowTextSuggestionMenu,
+                    std::vector<blink::WebTextSuggestionInfo>)
+
 // Adding a new message? Stick to the sort order above: first platform
 // independent InputMsg, then ifdefs for platform specific InputMsg, then
 // platform independent InputHostMsg, then ifdefs for platform specific
 // InputHostMsg.