Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h

Issue 2650113002: Phase II Step 2: Remove setIsPlaceholder() in updateImage() (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h b/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
index 239c4f3fc97b17e782f9b75d431a2268ae21a7bf..34e96e48f098a46f40b0f133bcc1d69f6ec55acd 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
@@ -33,7 +33,7 @@ class CORE_EXPORT ImageResourceInfo : public GarbageCollectedMixin {
virtual float devicePixelRatioHeaderValue() const = 0;
virtual const ResourceResponse& response() const = 0;
virtual ResourceStatus getStatus() const = 0;
- virtual bool isPlaceholder() const = 0;
+ virtual bool shouldShowPlaceholder() const = 0;
virtual bool isCacheValidator() const = 0;
virtual bool schedulingReloadOrShouldReloadBrokenPlaceholder() const = 0;
enum DoesCurrentFrameHaveSingleSecurityOrigin {
@@ -46,9 +46,6 @@ class CORE_EXPORT ImageResourceInfo : public GarbageCollectedMixin {
virtual bool hasCacheControlNoStoreHeader() const = 0;
virtual const ResourceError& resourceError() const = 0;
- // TODO(hiroshige): Remove this.
- virtual void setIsPlaceholder(bool) = 0;
-
// TODO(hiroshige): Remove this once MemoryCache becomes further weaker.
virtual void setDecodedSize(size_t) = 0;

Powered by Google App Engine
This is Rietveld 408576698