Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 26501002: Remove platform dependency upon page/Settings class which is a layering violation. (Closed)

Created:
7 years, 2 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove platform dependency upon page/Settings class which is a layering violation. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M Source/core/page/Settings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/Settings.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/platform/ScrollbarTheme.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/platform/ScrollbarTheme.cpp View 3 chunks +13 lines, -2 lines 0 comments Download
M Source/core/platform/mac/NSScrollerImpDetails.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
atreat
Remove layering violation
7 years, 2 months ago (2013-10-08 15:15:07 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-08 16:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26501002/1
7 years, 2 months ago (2013-10-08 16:18:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26501002/1
7 years, 2 months ago (2013-10-08 16:23:31 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 17:56:00 UTC) #5
Message was sent while issue was closed.
Change committed as 159136

Powered by Google App Engine
This is Rietveld 408576698