Issue 26501002: Remove platform dependency upon page/Settings class which is a layering violation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26501002: Remove platform dependency upon page/Settings class which is a layering violation. (Closed)

Created:
7 years, 2 months ago by atreat

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

Remove platform dependency upon page/Settings class which is a layering violation. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159136

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -9 lines)			Patch
M	Source/core/page/Settings.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/page/Settings.cpp	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/platform/ScrollbarTheme.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/platform/ScrollbarTheme.cpp	View	3 chunks	+13 lines, -2 lines	0 comments	Download
M	Source/core/platform/mac/NSScrollerImpDetails.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26501002/1

7 years, 2 months ago (2013-10-08 16:18:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26501002/1

7 years, 2 months ago (2013-10-08 16:23:31 UTC) #4

Message was sent while issue was closed.

Change committed as 159136