Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2650063004: Revert "Clean up new errors and warnings" (TBR) (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Clean up new errors and warnings" (TBR) Committed: https://github.com/dart-lang/sdk/commit/f711a00e132a5f11712a4e93c36371e1d44b4657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +34 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
It appears that dartk does not yet support generic method syntax and that this caused ...
3 years, 11 months ago (2017-01-25 00:53:14 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as f711a00e132a5f11712a4e93c36371e1d44b4657 (presubmit successful).
3 years, 11 months ago (2017-01-25 00:53:29 UTC) #4
scheglov
3 years, 11 months ago (2017-01-25 02:03:45 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698